Revert "Hide auto-generated files in code reviews and format Dockerfile templates" #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterDaveHello
approved these changes
Apr 24, 2024
SimenB
approved these changes
May 11, 2024
|
This is definitely why we should make the PR and commit clean so that it'll be much more easier to trace, revert, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2062
This means we need to click the "load diff" everywhere in the UI including the Commit view to see the actual changes. These files may be auto-generated in some cases, but we we need to verify the changes visually to ensure there are no intentional or unintentional malicious changes.